Bring back weekend & shutdown release restrictions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ack can you share a pointer to the tracker for the work this is waiting on? |
|
@rhartman93 I was thinking of https://issues.redhat.com/browse/EC-618 , but actually now I'm thinking this is safe to merge, it just won't do anything until the PR from EC-618 is merged. |
|
Actually this should not be merged until the change from enterprise-contract/ec-policies#999 is propagated around. |
|
I've determined that #999 has not yet propagated, so this is going to stay in draft for a while longer. |
These were added and then removed in the past because the checks were being incorrectly applied to all pipelines instead of just release pipelines. Now we have a mechanism to distinguish between release pipelines and non-release pipelines so it should be safe to bring back these schedule restrictions. Ref: https://issues.redhat.com/browse/EC-637
|
I think it's safe to merge now. Moving out of draft, and also rebasing. More details in EC-637. |
simonbaird
force-pushed
the
restore-schedule-restrictions
branch
from
acab623
to
92596d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added and then removed in the past because the checks were being incorrectly applied to all pipelines instead of just release pipelines.
Now we have a mechanism to distinguish between release pipelines and non-release pipelines so it should be safe to bring back these schedule restrictions.
Ref: https://issues.redhat.com/browse/EC-637