Allow usage of the *-oci-ta Task variants #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of EC-20, we are adding Task variants that support Trusted Artifacts with OCI storage. These have the suffix of `-oci-ta`. These Tasks function similarly to their counter-parts. The main difference is that they share data between them via resources in an OCI registry instead of file in a shared PVC on-cluster. This commit allows the `-oci-ta` Tasks to fullfill the required-tasks check. Additionally, the `summary` Task is no longer marked as required. This was the outcome after some investigation on its actual value. More context is available on the comments of EC-643. Finally, older entries that are no longer relevant have been removed from the list. Ref: EC-644 Signed-off-by: Luiz Carvalho <[email protected]>
ralphbean
approved these changes
May 17, 2024
|
@rhartman93, could you give a look here as well? I would like to have this merged soon as it's currently blocking the Trusted Artifacts work. 🙏 |
rhartman93
reviewed
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of EC-20, we are adding Task variants that support Trusted Artifacts with OCI storage. These have the suffix of
-oci-ta. These Tasks function similarly to their counter-parts. The main difference is that they share data between them via resources in an OCI registry instead of file in a shared PVC on-cluster.This commit allows the
-oci-taTasks to fullfill the required-tasks check.Additionally, the
summaryTask is no longer marked as required. This was the outcome after some investigation on its actual value. More context is available on the comments of EC-643.Finally, older entries that are no longer relevant have been removed from the list.
Ref: EC-644