Make ecosytem preflight failures non-blocking #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure about the pros and cons of this, but there are several teams who get surprised by this failure and want to exclude it. Because the task itself it not included in the required task lists, removing it entirely from the pipeline gets EC to pass. So for that reason I'm assuming it's acceptable to make it non-blocking. (The downside is that it's going to be much easier to ignore any failures produced by this test.)
|
Not sure if this is a good idea or not - it kind of depends how important those checks are considered to me. Update: After reading the description here I think it is probably a good idea. |
|
FYI @rhartman93 @ralphbean . |
|
I think this is good. It's catching a lot of users by surprise. New requirements, from their point of view. I think we should add it back in but with an effective date for end of Q1 2025 or something, to give lots of time for teams to adjust and comply. +1 from me to merge this as-is now and follow up later. |
ralphbean
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about the pros and cons of this, but there are several teams who get surprised by this failure and want to exclude it.
Because the task itself it not included in the required task lists, removing it entirely from the pipeline gets EC to pass. So for that reason I'm assuming it's acceptable to make it non-blocking.
(The downside is that it's going to be much easier to ignore any failures produced by this test.)
This PR has some useful context. The original intention was that the test should not be a hard requirement to begin with, which I think supports the goal of this PR.