feat: add Operator FIPS Compliance checks as required tasks #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashvardhannanavati
requested review from
rhartman93 and
ralphbean
as code owners
|
To be merged after konflux-ci/build-definitions#1741. thank you! :) |
|
@arewm @simonbaird FYI |
arewm
reviewed
Dec 18, 2024
|
This needs to be preceded by a mass update of users' .tekton/ files in git by sending PRs and MRs to add the task. |
yashvardhannanavati
force-pushed
the
fips_required_tasks
branch
from
38e70e2 to
a71be1a
Compare
CVP-4373. This commit adds fbc-fips-check as a required task to the FBC pipeline and fips-operator-bundle-check as a required task in the container pipeline. The commit also adds their repective TA versions. Signed-off-by: Yashvardhan Nanavati <[email protected]>
yashvardhannanavati
force-pushed
the
fips_required_tasks
branch
from
a71be1a to
1b329ec
Compare
The date has been revised to March 1, 2025. |
with fips-operator-bundle-check and fips-operator-bundle-check-ta being added as required tasks, they may fail even if the operator bundle is FIPS compliant for a specific OCP version. This is because on a bundle level, there's no way to determine the target OCP version for it and hence, we cannot apply the appropriate exception list during the check. This can only be determined when dealing with an FBC fragment. Hence, this commit adds the operator bundle check as informative. Signed-off-by: Yashvardhan Nanavati <[email protected]>
I was thinking this one (and #95) could be merged before that, and then the mass update, which would need to be done in advance of the effective on date, i.e. March 1st. See also EC-1063 and CVP-4376. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVP-4373. This commit adds fbc-fips-check as a required task to the FBC pipeline and fips-operator-bundle-check as a required task in the container pipeline. The commit also adds their repective TA versions.