Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Rollup build #11435

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

markdalgleish
Copy link
Member

This addresses a couple of issues in the Rollup build on Windows:

  • rollup-plugin-extensions doesn't resolve paths correctly on Windows, so we need to replace it with @rollup/plugin-node-resolve.
  • rollup-plugin-copy doesn't support absolute paths on Windows.

Copy link

changeset-bot bot commented Apr 11, 2024

⚠️ No Changeset found

Latest commit: e872c86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish merged commit 3f4536f into v7 Apr 11, 2024
6 of 8 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/fix-windows-rollup-build branch April 11, 2024 03:54
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant