feat(react-router): only render dev warnings in dev #13461
+19
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasTheTitan
changed the title
MichaelDeBoey
changed the title
MichaelDeBoey
requested changes
Apr 24, 2025
|
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
💿 Hey developer 👋warning for missing hydrate fallback was rendering on my prod application in addition to my dev environment. From looking in the code base, it looks like there is some precedent for only rendering these in dev. This PR tries to consolidate that and also updates the message to point at RR docs instead of Remix docs.There are a ton of ways to do this, so curious for feedback! For example, I wasn't quite sure where the best place to consolidate
ENABLE_DEV_WARNINGSwas.