-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(integer): support integer field type #11
fix(integer): support integer field type #11
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @jguddas! Could you update this with the main, and then we can merge it? |
Done. |
88b175f
to
724409f
Compare
Approving! |
Merged and released |
Hi @jguddas , thank you for your contribution! 😄 Wondering if you're using this library as part of your work at the LEGO group? It's really cool to see it used outside of Remote ❤️ |
I have to disappoint you @tomaspinho, the contribution was just for fun, I just really like JSON schema. |
SON Schemas fields with
type: "integer"
allow values like1.5
.Now in this PR they are considered invalid. If you want
1.5
to be allowed, usetype: "number"
.Example:
Before:
{tabs: 2.5}
// valid{tabs: 2.5}
// error: "Must not contain decimal points. E.g. 5 instead of 5.5"