Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVXP-2603: chore(next): use json schema test suite #121

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

lukad
Copy link
Collaborator

@lukad lukad commented Feb 5, 2025

This adds the json schema test suite repo as a submodule and defines a test for each test case from the test suite dynamically.

.gitmodules Show resolved Hide resolved
next/test/validation/json_schema_test_suite.test.ts Outdated Show resolved Hide resolved
next/test/validation/json_schema_test_suite.test.ts Outdated Show resolved Hide resolved
thien-remote
thien-remote previously approved these changes Feb 6, 2025
Copy link
Collaborator

@thien-remote thien-remote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3 most impactful files!

@lukad lukad marked this pull request as ready for review February 6, 2025 10:59
@lukad lukad requested a review from antoniocapelo February 6, 2025 10:59
Copy link
Collaborator

@antoniocapelo antoniocapelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved since the new suite is skipped and we can iterate in future PRs

@lukad lukad merged commit 413b077 into main Feb 6, 2025
3 checks passed
@lukad lukad deleted the devxp-2603-use-json-schema-test-suite branch February 6, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants