Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVXP-2605: feat(next): implement x-jsf-presentation #127

Merged
merged 8 commits into from
Feb 10, 2025
Merged

DEVXP-2605: feat(next): implement x-jsf-presentation #127

merged 8 commits into from
Feb 10, 2025

Conversation

lukad
Copy link
Collaborator

@lukad lukad commented Feb 7, 2025 •
edited
Loading

This implements basic features of x-jsf-presentation.
I've made some changes to existing code:

  • renamed buildFieldsSchema to buildFieldSchema
    • it returns a single field
    • if the schema is an object schema it calls buildFieldObject
  • the buildFields function now calls buildFieldObject and returns its fields

lukad
lukad commented Feb 7, 2025
View reviewed changes
next/src/types.ts Show resolved Hide resolved
@lukad lukad force-pushed the implement-x-jsf-presentation branch from 7d073cd to c372829 Compare February 7, 2025 13:05
@lukad lukad force-pushed the implement-x-jsf-presentation branch from c372829 to 5ede3c5 Compare February 7, 2025 13:23
sandrina-p
sandrina-p requested changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@sandrina-p sandrina-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! This title caught my attention, so I came here with a quicker review ;)

next/src/field/schema.ts Show resolved Hide resolved
next/src/field/schema.ts Outdated Show resolved Hide resolved
next/src/field/schema.ts Outdated Show resolved Hide resolved
next/src/field/schema.ts Show resolved Hide resolved
next/src/field/schema.ts Show resolved Hide resolved
@lukad lukad marked this pull request as ready for review February 7, 2025 17:16
@dragidavid
Copy link
Collaborator

Hey @lukad - the changes look good to me and makes sense. I'll let @sandrina-p go through this once more though since I might be missing something. This keyword is custom after all 😄

dragidavid
dragidavid previously approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@dragidavid dragidavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this for now. We can make any necessary changes later as I think those would be smaller tweaks anyway.

sandrina-p
sandrina-p previously approved these changes Feb 10, 2025
View reviewed changes
@lukad lukad merged commit 55b8ee8 into main Feb 10, 2025
3 checks passed
@lukad lukad deleted the implement-x-jsf-presentation branch February 10, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandrina-p sandrina-p sandrina-p approved these changes

@dragidavid dragidavid dragidavid left review comments

@thien-remote thien-remote Awaiting requested review from thien-remote

@antoniocapelo antoniocapelo Awaiting requested review from antoniocapelo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukad @dragidavid @sandrina-p