DEVXP-XXX: handle paths #129
Merged
+388
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this change ensures that the paths are created in a way that matches how we generate the `formErrors` in the main package
dragidavid
commented
Feb 12, 2025
dragidavid
commented
Feb 12, 2025
dragidavid
commented
Feb 13, 2025
lukad
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies a couple suggestions from this previous PR, thanks @thien-remote.
Changes are:
validatorto make the validations better informat.tsFormatenum from thejson-schema-typedpackage instead of our custom solution (again in `format.ts)pathkey across the package - now matching the way we do it in the original package