draft: Gracefully handle when multiple conditional branches are true #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following schema:
When the field
word
has a value ofhello
, you'd expect the attributes to be the following:This in the
main
branch does not work at the moment correctly, because on every evaluation of successfully valid conditional branch that we apply, we also runremoveConditionalStateAttributes
. This means that the expected result only happens here.But, we have no way of saying "keep the results from ALL branches before removing whats stale". It considers the previously evaluated branch as stale.
What I've done here makes a unit test for this pass... but I haven't fully battle tested. And I very much hate the solution and I'm convinced theres a better way to do this that isn't as truly abhorrent as this.