fix(select/radio): Add support for options with boolean type #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remotecom
commented
Aug 16, 2024
sandrina-p
reviewed
Aug 16, 2024
sandrina-p
reviewed
Aug 16, 2024
sandrina-p
reviewed
Aug 19, 2024
sandrina-p
changed the title
brennj
approved these changes
Aug 19, 2024
sandrina-p
force-pushed
the
fix/radio-boolean-type
branch
from
bda5b44 to
c30b5c6
Compare
sandrina-p
force-pushed
the
fix/radio-boolean-type
branch
from
c30b5c6 to
331d08e
Compare
sandrina-p
reviewed
Aug 19, 2024
| @@ -8,7 +8,9 @@ import { | |||
| JSONSchemaBuilder, | |||
| schemaInputTypeText, | |||
| schemaInputTypeRadioDeprecated, | |||
| schemaInputTypeRadio, | |||
| schemaInputTypeRadioString, | |||
There was a problem hiding this comment.
FYI @Arcombe-Remote , I've renamed the PR title to follow conventional commits :) fix(select/radio): Add support for options with boolean type (#89)
There was a problem hiding this comment.
🎉 Version 0.11.3-beta.0 published!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding validation for boolean values in Radio input type.
Internal ticket
Problem
Currently the validation for Radio inputs was set up for either
stringornumbertypes. When usingbooleanvalues the validation defaulted tostringand errored even if it was correct.Solution
Adding a validation option for boolean types.