Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: first implementation #1

Merged
merged 1 commit into from
Mar 27, 2024
Merged

feat: first implementation #1

merged 1 commit into from
Mar 27, 2024

Conversation

pquadri
Copy link
Collaborator

@pquadri pquadri commented Mar 26, 2024 •
edited
Loading

  • add a CI
  • add tests for simple logger (not in json format but plain text, i used the Meltano one as example)

@pquadri pquadri requested a review from eliyarson March 26, 2024 17:33
@pquadri pquadri self-assigned this Mar 26, 2024
pquadri
pquadri commented Mar 26, 2024
View reviewed changes
tests/test_formatter.py Outdated Show resolved Hide resolved
@pquadri pquadri force-pushed the feat/first-implementation branch from 952436a to 33b8132 Compare March 27, 2024 09:35
@pquadri pquadri force-pushed the feat/first-implementation branch from ef8d7af to 1945182 Compare March 27, 2024 10:00
@pquadri pquadri merged commit cdf57c6 into main Mar 27, 2024
3 checks passed
@pquadri pquadri deleted the feat/first-implementation branch March 27, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliyarson eliyarson Awaiting requested review from eliyarson

Assignees

@pquadri pquadri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pquadri