Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make timeline controls accessible on mobile #4872

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Make timeline controls accessible on mobile #4872

merged 3 commits into from
Feb 12, 2025

Conversation

HiteshChoudhary0098
Copy link
Contributor

UI update

Old UI

Screenshot 2025-02-07 at 11 55 04 PM

New UI
Screenshot 2025-02-07 at 11 34 43 PM
Screenshot 2025-02-07 at 11 34 47 PM

Changes

  1. Remove Timeline Zoom Slider in mobile
  2. Show playback control on left.
  3. Move all other controls to the right and make the control panel scrollable.

@vercel Vercel
Copy link

vercel bot commented Feb 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 10:02pm
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 10:02pm

@JonnyBurger
Copy link
Member

Thanks not bad! A few things that don't make sense for me yet:

  1. The space here is not needed anymore since it was for aligning the controls in the center. It can be removed.
    image

  2. There is no indication that one can scroll to the right. Could we add a fade on both sides if it is scrollable? Could look like this:
    image

  3. I suggest we remove the FpsCounter as it causes a layout shift when play/pause is toggled

@HiteshChoudhary0098
Copy link
Contributor Author

Screenshot 2025-02-11 at 3 18 48 AM Screenshot 2025-02-11 at 3 18 53 AM Screenshot 2025-02-11 at 3 18 57 AM

@JonnyBurger
Copy link
Member

Thanks a lot! Looks good!

/tip $250

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 12, 2025

@HiteshChoudhary0098: You just got a $250 tip! 👉 Complete your Algora onboarding to collect your payment.

@JonnyBurger JonnyBurger merged commit ac12b36 into remotion-dev:main Feb 12, 2025
12 checks passed
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 12, 2025

🎉🎈 @HiteshChoudhary0098 has been awarded $250! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
💰 Rewarded
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HiteshChoudhary0098 @JonnyBurger