Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@remotion/player: Show full time when the Player has ended and duration is an integer in seconds #4874

Merged
merged 1 commit into from
Feb 9, 2025
Merged

@remotion/player: Show full time when the Player has ended and duration is an integer in seconds #4874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/player/src/PlayerTimeLabel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,13 @@ export const PlayerTimeLabel: React.FC<{
};
}, [maxTimeLabelWidth]);

// If the video ended and is not looping, it should show 0:04 / 0:04 instead of 0:03 / 0:04
const isLastFrame = frame === durationInFrames - 1;
const frameToDisplay = isLastFrame ? frame + 1 : frame;

return (
<div style={timeLabel}>
{formatTime(frame / fps)} / {formatTime(durationInFrames / fps)}
{formatTime(frameToDisplay / fps)} / {formatTime(durationInFrames / fps)}
</div>
);
};
Loading