Skip to content

Update deprecated keywords #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dc-mak
Copy link
Collaborator

@dc-mak dc-mak commented Mar 12, 2025

Owned -> RW
Block -> W
extract -> focus

rems-project/cerberus#854 (commit 0832c78) deprecated some keywords in favour of new replacements and this commit updates the tutorial examples to use them to be less noisy in the CI.

The tutorial docs also need to be updated.

dc-mak added 2 commits March 12, 2025 18:45
Owned -> RW
Block -> W
extract -> focus

rems-project/cerberus#854 (commit 0832c78) deprecated some keywords in
favour of new replacements and this commit updates the tutorial examples
to use them to be less noisy in the CI.

The tutorial docs also need to be updated.
@bcpierce00
Copy link
Collaborator

Note that all work on the tutorial is happening in the testing-tutorial branch at the moment. (I've wondered whether we should commit it back to the main branch, but everything is all torn apart and I don't want to overwrite the working version of the tutorial until it converges.)

I can make this change in that branch too.

@bcpierce00
Copy link
Collaborator

(Making this little change now to make CI happy is fine, of course. I just don't want people to waste time making big improvements in the main branch.)

@dc-mak
Copy link
Collaborator Author

dc-mak commented Mar 12, 2025

Thanks for lmk! Proceed as you see fit. I can also share the commands I used for the updates if that helps.

@dc-mak dc-mak marked this pull request as ready for review March 12, 2025 23:05
@bcpierce00
Copy link
Collaborator

Please do!

@dc-mak
Copy link
Collaborator Author

dc-mak commented Mar 13, 2025

This is just for the .c files, I just realised same needs to be done for the .h files too.

find . -name '*.c' -exec sed -i 's/Owned/RW/g' '{}' \;
find . -name '*.c' -exec sed -i 's/Block/W/g' '{}' \;
find . -name '*.c' -exec sed -i 's/extract/focus/g' '{}' \;
find . -name '*.c' -exec sed -i 's/focusing/extracting/g' '{}' \;
find . -name '*.c' -exec sed -i 's/llvm_focus/llvm_extract/g' '{}' \;

@bcpierce00
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants