Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tuple IDs for graph nodes in processor #219

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

renatahodovan
Copy link
Owner

Joining the parts of node identifiers is unnecessary and loses information by concealing the boundaries of rule names, label names, and label indices. The patch employs tuples instead of concatenated strings.

Joining the parts of node identifiers is unnecessary and loses
information by concealing the boundaries of rule names, label names,
and label indices. The patch employs tuples instead of concatenated strings.
@renatahodovan renatahodovan requested a review from akosthekiss May 20, 2024 13:25
@coveralls
Copy link

Coverage Status

coverage: 85.904% (-0.3%) from 86.253%
when pulling edd51a4 on tuple-ids-v2
into 5e8d0c4 on master.

Copy link
Collaborator

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akosthekiss akosthekiss merged commit 5ee7407 into master May 20, 2024
46 checks passed
@akosthekiss akosthekiss deleted the tuple-ids-v2 branch May 20, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants