Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter immutable rules out from annotations #241

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Filter immutable rules out from annotations #241

merged 1 commit into from
Oct 28, 2024
+10 −13

Conversation

renatahodovan
Copy link
Owner

Immutable rules were filtered out in the previous version as well, but it was repeatedly performed in the mutators. This is moved into Annotations now, which simplifies the code.

@renatahodovan
Filter immutable rules out from annotations
b83a777 
Immutable rules were filtered out in the previous version as well,
but it was repeatedly performed in the mutators. This is moved
into Annotations now, which simplifies the code.
@coveralls
Copy link

Coverage Status

coverage: 85.971%. remained the same
when pulling b83a777 on filter-immutable
into b10b085 on master.

akosthekiss
akosthekiss approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akosthekiss akosthekiss merged commit d11a224 into master Oct 28, 2024
46 checks passed
@akosthekiss akosthekiss deleted the filter-immutable branch October 28, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosthekiss akosthekiss akosthekiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renatahodovan @coveralls @akosthekiss