fix(workers/repository): Pass correct lock files when updating a dependency in multiple input files #27898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies the fix from renovatebot#27319 to non-lockFileMaintanence updates so that the correct lockFiles attribute gets passed to the manager's updateArtifacts function when updating single dependencies. Without this change, the same lockFiles attribute gets passed along with every packageFileName, which causes the pip-compile manager to update the same lock file multiple times when a dependency is updated in multiple input files.
mbudnek
changed the title
viceice
approved these changes
Mar 15, 2024
|
🎉 This PR is included in version 37.249.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This applies the fix from #27319 to non-lockFileMaintanence updates so that the correct
lockFilesattribute gets passed to the manager'supdateArtifactsfunction when updating single dependencies. Without this change, the samelockFilesattribute gets passed along with everypackageFileName, which causes the pip-compile manager to update the same lock file multiple times when a dependency is updated in multiple input files.Context
Discussion of the impact of this bug on the pip-compile manager: #27761
Original PR that applied this workaround to lockFileMaintanence: #27319
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: