-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bundler): add git refs support #32362
base: main
Are you sure you want to change the base?
Conversation
Hey team, do you need anything from me to get this merged? Thank you 🙏 cc @rarkins |
2a37257
to
3f4ae93
Compare
Merged failed with this:
Not sure why it was caught in the merge queue and not in PR. |
Now it failed here! |
There now seems to be a refactoring of the existing and non git refs logic too? |
7260b0b
to
53e1d78
Compare
Hey @rarkins , @viceice suggested I moved the regex at the module levels, so I did this for all the regexes here. |
Also I'd need your help on the CI: I have not added any snapshots, just updated the existing ones (as some were already containing what was not yet parsed a gitrefs). How can I make this pass? |
I was referring to the changes under the "if (gemMatch)" logic branch. Is that logic meant to be the same as before? That logic is now all red and green in the diff. |
Yes that's the same. |
There's a change in logic regarding sourceName. Is it intentional or accidental? |
Hu, that's my bad, I failed to put a comment about this. As |
I think it was ok to make that change (I agree with you re: mutual exclusivity) but I wanted to check that it's intentional. |
Changes
Added git refs support for the bundler manager.
Context
Fixes #30990
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: