feat(config): allow multiple branch/pr limits #32556
Open
+528
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
requested changes
Nov 15, 2024
viceice
reviewed
Nov 18, 2024
secustor
reviewed
Nov 18, 2024
rarkins
requested changes
Nov 21, 2024
Comment on lines
212
to
216
|
|
||
| logger.debug( | ||
| `Open PR Count: ${counts.get('PullRequests')?.current}, Existing Branch Count: ${counts.get('Branches')?.current}, Hourly PR Count: ${counts.get('HourlyPullRequests')?.current}`, | ||
| ); | ||
|
|
There was a problem hiding this comment.
Is this logged once per branch, regardless of whether any limits are set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allows concurrent and hourly limits to be set in package rules. (implemented everything mentioned in this comment)
Context
Closes: #10546
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
Old Behaviour: follows hourly limits, 1, 2, 3
New Behaviour 1, 2, 3
Note: Test descriptions present in readme of each test repo