refactor(schedule): use croner library to check schedule
#32573
+118
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulGautamSingh
changed the title
cron-parser library to check schedulecroner library to check schedule
RahulGautamSingh
requested review from
rarkins,
secustor and
viceice
and removed request for
rarkins and
secustor
viceice
reviewed
Nov 18, 2024
viceice
reviewed
Nov 19, 2024
secustor
reviewed
Nov 21, 2024
It was disicussed internally to leave it as we will need to add more complexity to support something that is essentially an invalid configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use the nextRun() method from croner library to get the next scheduled date. And compare it to current date to check if current date lies in the cron schedule.
Context
Cover implementation requirements of: #32414
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: