fix(gradle): Strip /. prefix when searching for gradlew
#32604
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candrews
force-pushed
the
patch-4
branch
2 times, most recently
from
7d0f976
to
0a2368c
Compare
`gradleWrapperFileName` returns `./gradlew` when not running on Windows. `findUpLocal` returns unexpected results due to the `./` prefix, therefore strip the `./` prefix when calling `findUpLocal`.
Co-authored-by: Michael Kriese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
gradleWrapperFileNamereturns./gradlewwhen not running on Windows.findUpLocalreturns unexpected results due to the./prefix, therefore strip the./prefix when callingfindUpLocal.Context
This change fixes an issue where Renovate debug logs
Found Gradle dependency lockfiles but no gradlew - aborting updateeven whengradlewexists, resulting in gradle lockfiles not being updated as expected.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: