Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "-X" option to avoid waiting for other transactions #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

farrokhi
Copy link

@farrokhi farrokhi commented Jun 3, 2017

There was a conservative wait[1] for all existing transaction to
finish before repacking a table. This may not be desired on a busy
database on which you have long running transaction, which may block
pg_repack to do the job. This option will display a warning message,
but continues the process in such cases.

[1] http://lists.pgfoundry.org/pipermail/reorg-general/2015-October/000318.html

@andreasscherbaum
Copy link
Collaborator

@farrokhi Can you please rebase the PR? This will also trigger the checks.
An update for the documentation is also missing.

The name "paranoia" is maybe not the best choice, can you think of a better name?

@farrokhi
Copy link
Author

Thanks for the feedback. I updated the PR (including documents). Please kindly review.

@andreasscherbaum
Copy link
Collaborator

Did you rebase the PR? It includes unrelated changes from other commits.

There was a conservative wait[1] for all existing transaction to
finish before repacking a table. This may not be desired on a busy
database on which you have long running transaction, which may block
pg_repack to do the job. This option will display a warning message,
but continues the process in such cases.

[1] http://lists.pgfoundry.org/pipermail/reorg-general/2015-October/000318.html
@farrokhi
Copy link
Author

I cleaned up the same PR. It should have a single commit with relevant changes now.

@andreasscherbaum
Copy link
Collaborator

File-wise it looks good. Will place it in our next review cycle. Thanks.

@dvarrazzo
Copy link
Member

Why -X at all?

I have looked at them, and Every Single Option has a short option. It seems a bad idea (thankfully we have almost run over the entire alphabet).

I would start from here to stop adding one-letter options.

Maybe we should also deprecate most of them, except the most obvious ones, in a future non-backward compatible version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants