feat: add support for eip5792 getCapabilities and sendCalls #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indow events with ids
…allet-call-paymaster
enesozturk
reviewed
Aug 6, 2024
| @@ -47,6 +48,10 @@ export function EthersGetCallsStatusTest() { | |||
| } | |||
| } | |||
| function isGetCallsStatusSupported(): boolean { | |||
| // Replace with capability check | |||
There was a problem hiding this comment.
added a proper comment for following prs
enesozturk
reviewed
Aug 6, 2024
| @@ -98,7 +112,8 @@ export function EthersSendCallsWithPaymasterServiceTest() { | |||
| ) | |||
| } | |||
|
|
|||
| return false | |||
| // Replace with capability check | |||
There was a problem hiding this comment.
Same, is it a todo? Should be replaced with something else?
There was a problem hiding this comment.
If it requires more polishing or would be handled in another PR etc, would it be better to give more context to devs?
There was a problem hiding this comment.
Actually a todo yes. Ty
There was a problem hiding this comment.
Actually there's a typing issue. I'll change this in a different PR 🙏
Would like to get this merged
enesozturk
reviewed
Aug 6, 2024
enesozturk
reviewed
Aug 6, 2024
enesozturk
approved these changes
Aug 6, 2024
svenvoskamp
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes
#2527
#2320
Type of change
Checklist