chore: test ethers verify API + AppKit in iframe verify test case #2831

chris13524 · 2024-09-10T02:06:18Z

Description

Adds missing test coverage for Verify API on the Ethers SDK.

Also adds test coverage for https://github.com/WalletConnect/cloud-app/pull/1509

Remaining work:

Add parameter so Cloud App's execution of these tests can specify a custom Verify Server: https://github.com/WalletConnect/cloud-app/pull/1509

Fixes APKT-1445

Type of change

Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)

vercel · 2024-09-10T02:06:22Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
appkit-gallery-new	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 21, 2024 5:24pm
appkit-laboratory	✅ Ready (Inspect)	Visit Preview		Nov 21, 2024 5:24pm
appkit-vue-solana	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 21, 2024 5:24pm
appkit-wagmi-cdn-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 21, 2024 5:24pm
vue-wagmi-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 21, 2024 5:24pm
web3modal-gallery	✅ Ready (Inspect)	Visit Preview		Nov 21, 2024 5:24pm
web3modal-laboratory	✅ Ready (Inspect)	Visit Preview		Nov 21, 2024 5:24pm

github-actions · 2024-09-10T02:08:21Z

Coverage Report for Coverage

Status	Category	Percentage	Covered / Total
🔵	Lines	335.7%	4838 / 23584
🔵	Statements	335.7%	4838 / 23584
🔵	Functions	368.88%	388 / 1431
🔵	Branches	475.80999999999995%	745 / 1724

File Coverage

No changed files found.

Generated in workflow #7526 for commit 9ea67a6 by the Vitest Coverage Report Action

github-actions · 2024-09-10T02:08:58Z

♻️ Vite-Size ♻️

Size Difference

	Size (kb)	Gzip (kb)
Total Diff.	0	0

Current Size

Name	Size (kb)	Gzip (kb)
assets/index-ClB9DH0L.js	1602.086	464.674
assets/noble-curves.js	31.941	12.782
assets/2.19.6_bufferutil.js	2.789	1.328
assets/index.js	9.516	3.191
assets/index2.js	102.248	29.113
assets/index3.js	304.387	87.28
assets/walletconnect-ethereum-provider.js	438.506	138.106
assets/index4.js	11.601	3.206
assets/w3m-modal.js	6.988	2.506
assets/index5.js	12.673	4.695
assets/hooks.module.js	74.437	25.583
assets/walletconnect-modal-ui.js	112.43	34.326
index.html	0.329	0.238
Total Size	2709.931	807.028

Base Size

Name	Size (kb)	Gzip (kb)
assets/index-ClB9DH0L.js	1602.086	464.674
assets/noble-curves.js	31.941	12.782
assets/2.19.6_bufferutil.js	2.789	1.328
assets/index.js	9.516	3.191
assets/index2.js	102.248	29.113
assets/index3.js	304.387	87.28
assets/walletconnect-ethereum-provider.js	438.506	138.106
assets/index4.js	11.601	3.206
assets/w3m-modal.js	6.988	2.506
assets/index5.js	12.673	4.695
assets/hooks.module.js	74.437	25.583
assets/walletconnect-modal-ui.js	112.43	34.326
index.html	0.329	0.238
Total Size	2709.931	807.028

…/test-ethers-verify

changeset-bot · 2024-11-12T17:32:17Z

⚠️ No Changeset found

Latest commit: 9ea67a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

linear · 2024-11-12T19:35:40Z

APKT-1445 Test case for nested iframe case

github-actions · 2024-11-12T19:36:36Z

	Warnings
⚠️	Workflow file .github/workflows/ui_tests.yml has been modified
⚠️	Testing spec changed

Generated by 🚫 dangerJS against 9ea67a6

tomiir · 2024-11-13T14:57:55Z

apps/laboratory/tests/shared/fixtures/w3m-fixture.ts

@@ -30,6 +30,18 @@ export const testM = timingFixture.extend<ModalFixture>({
    await use(modalPage)
  }
 })
+export const testMEthers = timingFixture.extend<ModalFixture>({


How is this different fromcthe default testM? / why does it need a special case?

This should be refactored in the latest revision

…/test-ethers-verify

… specific projects only

tomiir · 2024-11-13T17:01:57Z

apps/laboratory/next.config.mjs

  object-src 'none';
  base-uri 'self';
  form-action 'self';
-  frame-ancestors 'none';
+  frame-ancestors ${verifyApiNestedIframesTestOuterDomain};


do we need to conditionally add this on test env?

iirc adding it conditionally was tricky because the app is always built with NODE_ENV production, so it didn't know if it was building for tests or not

Didn't bother going deeper I don't think, so hardcoded an intentionally-long domain here which wouldn't be valid anyway

chore: test ethers verify API

fe07db7

chris13524 self-assigned this Sep 10, 2024

vercel bot deployed to Preview – web3modal-gallery September 10, 2024 02:08 View deployment

vercel bot deployed to Preview – web3modal-laboratory September 10, 2024 02:10 View deployment

chore: fix name conflicts

c216164

vercel bot deployed to Preview – web3modal-gallery September 10, 2024 02:18 View deployment

vercel bot deployed to Preview – web3modal-laboratory September 10, 2024 02:20 View deployment

chris13524 requested a review from tomiir September 10, 2024 02:43

Merge branch 'main' of https://github.com/reown-com/appkit into chore…

166da40

…/test-ethers-verify

vercel bot deployed to Preview – appkit-vue-solana November 12, 2024 17:34 View deployment

vercel bot deployed to Preview – vue-wagmi-example November 12, 2024 17:35 View deployment

vercel bot deployed to Preview – appkit-wagmi-cdn-example November 12, 2024 17:37 View deployment

vercel bot had a problem deploying to Preview – appkit-laboratory November 12, 2024 17:37 Failure

vercel bot deployed to Preview – web3modal-gallery November 12, 2024 17:39 View deployment

Chris Smith added 3 commits November 12, 2024 14:32

chore: fixup ethers tests

1cb5095

chore: enable verify tests

b2846d9

chore: update README

6dff309

chris13524 changed the title ~~chore: test ethers verify API~~ chore: test ethers verify API + AppKit in iframe verify test case Nov 12, 2024

vercel bot deployed to Preview – appkit-vue-solana November 12, 2024 19:37 View deployment

vercel bot deployed to Preview – vue-wagmi-example November 12, 2024 19:37 View deployment

vercel bot deployed to Preview – appkit-wagmi-cdn-example November 12, 2024 19:39 View deployment

vercel bot deployed to Preview – web3modal-gallery November 12, 2024 19:39 View deployment

chore: test AppKit in iframe

c4f313f

vercel bot deployed to Preview – appkit-laboratory November 12, 2024 19:44 View deployment

vercel bot deployed to Preview – web3modal-gallery November 13, 2024 12:53 View deployment

vercel bot deployed to Preview – vue-wagmi-example November 13, 2024 12:56 View deployment

vercel bot deployed to Preview – appkit-laboratory November 13, 2024 12:56 View deployment

tomiir approved these changes Nov 13, 2024

View reviewed changes

Chris Smith added 2 commits November 13, 2024 10:30

Merge branch 'main' of https://github.com/reown-com/appkit into chore…

85b7236

…/test-ethers-verify

chore: remove redundant fixture & properly implement scoping tests to…

b1b59ab

… specific projects only

vercel bot deployed to Preview – appkit-vue-solana November 13, 2024 15:42 View deployment

vercel bot deployed to Preview – vue-wagmi-example November 13, 2024 15:42 View deployment

vercel bot deployed to Preview – web3modal-gallery November 13, 2024 15:45 View deployment

chore: run prettier

32827b7

vercel bot deployed to Preview – web3modal-gallery November 13, 2024 15:49 View deployment

vercel bot deployed to Preview – appkit-vue-solana November 13, 2024 15:52 View deployment

vercel bot deployed to Preview – appkit-laboratory November 13, 2024 15:52 View deployment

vercel bot deployed to Preview – appkit-wagmi-cdn-example November 13, 2024 15:54 View deployment

vercel bot deployed to Preview – vue-wagmi-example November 13, 2024 15:54 View deployment

tomiir reviewed Nov 13, 2024

View reviewed changes

Merge branch 'main' into chore/test-ethers-verify

657c46f

vercel bot deployed to Preview – appkit-wagmi-cdn-example November 14, 2024 14:29 View deployment

vercel bot deployed to Preview – appkit-vue-solana November 14, 2024 14:29 View deployment

vercel bot deployed to Preview – web3modal-gallery November 14, 2024 14:31 View deployment

vercel bot deployed to Preview – vue-wagmi-example November 14, 2024 14:34 View deployment

vercel bot deployed to Preview – appkit-laboratory November 14, 2024 14:35 View deployment

Merge branch 'main' into chore/test-ethers-verify

9ea67a6

vercel bot deployed to Preview – appkit-wagmi-cdn-example November 21, 2024 17:19 View deployment

vercel bot deployed to Preview – vue-wagmi-example November 21, 2024 17:19 View deployment

vercel bot deployed to Preview – appkit-gallery-new November 21, 2024 17:21 View deployment

vercel bot deployed to Preview – appkit-vue-solana November 21, 2024 17:24 View deployment

vercel bot deployed to Preview – appkit-laboratory November 21, 2024 17:24 View deployment

chris13524 merged commit 29bc14c into main Nov 21, 2024
19 checks passed

chris13524 deleted the chore/test-ethers-verify branch November 21, 2024 20:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: test ethers verify API + AppKit in iframe verify test case #2831

chore: test ethers verify API + AppKit in iframe verify test case #2831

chris13524 commented Sep 10, 2024 •

edited

Loading

vercel bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

changeset-bot bot commented Nov 12, 2024 •

edited

Loading

linear bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024 •

edited

Loading

tomiir Nov 13, 2024

chris13524 Nov 21, 2024

tomiir Nov 13, 2024

chris13524 Nov 21, 2024 •

edited

Loading

chore: test ethers verify API + AppKit in iframe verify test case #2831

chore: test ethers verify API + AppKit in iframe verify test case #2831

Conversation

chris13524 commented Sep 10, 2024 • edited Loading

Description

Type of change

vercel bot commented Sep 10, 2024 • edited Loading

github-actions bot commented Sep 10, 2024 • edited Loading

Coverage Report for Coverage

github-actions bot commented Sep 10, 2024 • edited Loading

♻️ Vite-Size ♻️

Size Difference

Current Size

Base Size

changeset-bot bot commented Nov 12, 2024 • edited Loading

⚠️ No Changeset found

linear bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024 • edited Loading

tomiir Nov 13, 2024

Choose a reason for hiding this comment

chris13524 Nov 21, 2024

Choose a reason for hiding this comment

tomiir Nov 13, 2024

Choose a reason for hiding this comment

chris13524 Nov 21, 2024 • edited Loading

Choose a reason for hiding this comment

chris13524 commented Sep 10, 2024 •

edited

Loading

vercel bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

changeset-bot bot commented Nov 12, 2024 •

edited

Loading

github-actions bot commented Nov 12, 2024 •

edited

Loading

chris13524 Nov 21, 2024 •

edited

Loading