Feat/tma socials #3025
Feat/tma socials #3025
Conversation
# Conflicts: # packages/appkit/src/client.ts
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
♻️ Vite-Size ♻️Size Difference
Current Size
Base Size
|
# Conflicts: # packages/appkit/src/client.ts
| const secureSiteDomain = process.env.NEXT_PUBLIC_SECURE_SITE_SDK_URL | ||
| ? new URL(process.env.NEXT_PUBLIC_SECURE_SITE_SDK_URL).origin | ||
| : '' | ||
| const secureSiteDomain = 'https://b1a9fa46.secure-appkit-sdk.pages.dev' |
There was a problem hiding this comment.
remember to remove this later 🙏
|
|
||
| if (isLoginEmailUsed) { | ||
| const { isConnected } = await this.authProvider.isConnected() | ||
| if (isConnected) { | ||
| await this.setAuthProvider() | ||
| } else { | ||
| this.appKit?.setLoading(false) | ||
| } | ||
| this.appKit?.setLoading(isLoginEmailUsed) | ||
| } | ||
|
|
||
| const { isConnected } = await this.authProvider.isConnected() | ||
| if (isConnected) { | ||
| await this.setAuthProvider() | ||
| } else if (isLoginEmailUsed) { | ||
| this.appKit?.setLoading(false) |
There was a problem hiding this comment.
you sure about this? the sync function is triggered on re-connection so I think you do need to check if isLoginEmailUSed
| if (isLoginEmailUsed) { | ||
| this.appKit?.setLoading(isLoginEmailUsed) | ||
| } |
There was a problem hiding this comment.
is this needed?? isLoginEmailUsed is already a bool
| if (typeof window === 'undefined' || typeof document === 'undefined') { | ||
| return | ||
| } |
There was a problem hiding this comment.
we have HelperUtil.isClient
| @@ -629,4 +635,58 @@ export class AppKit { | |||
|
|
|||
| return this.initPromise | |||
| } | |||
|
|
|||
| private async checkExistingConnection() { | |||
There was a problem hiding this comment.
can we rename to something like checkExistingSocialConnection ?
| setTimeout(() => { | ||
| this.checkExistingConnection() | ||
| }, 0) |
There was a problem hiding this comment.
do you need to trigger this here? shouldn't you do after / during authConnector initialization?
| @@ -25,7 +26,8 @@ export const SafeLocalStorageKeys = { | |||
| CONNECTED_SOCIAL: '@appkit/connected_social', | |||
| CONNECTED_SOCIAL_USERNAME: '@appkit/connected_social_username', | |||
| RECENT_WALLETS: '@appkit/recent_wallets', | |||
| DEEPLINK_CHOICE: 'WALLETCONNECT_DEEPLINK_CHOICE' | |||
| DEEPLINK_CHOICE: 'WALLETCONNECT_DEEPLINK_CHOICE', | |||
| SOCIAL_PROVIDER: '@appkit/social_provider' | |||
| export const SECURE_SITE_SDK = 'https://b1a9fa46.secure-appkit-sdk.pages.dev/sdk' | ||
| // Process.env['NEXT_PUBLIC_SECURE_SITE_SDK_URL'] || 'https://secure.walletconnect.org/sdk' |
|
closing as this is veeery out of date. will link the new PR |
Description
Implemented social login flow that works in telegram mini apps. It uses direct redirects instead of popup window for social login approval.
TODO: remove custom secure site urls before merge. This would also cause the test app linked here to stop working as its using latest vercel deployment of this PR
Type of change
Test app
https://t.me/appkit_test_ggr_bot/appkit
Checklist