Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add INITIALIZE event to track configuration options #3267

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Nov 19, 2024

Description

Adds INITIALIZE event to track configuration options

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 680d2eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 11:58am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 11:58am
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 11:58am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 11:58am
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 11:58am
web3modal-gallery 🛑 Canceled (Inspect) 💬 Add feedback Nov 21, 2024 11:58am

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 176.75% 1304 / 2810
🔵 Statements 176.75% 1304 / 2810
🔵 Functions 184.29999999999998% 138 / 244
🔵 Branches 241% 243 / 327
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client.ts 50.22% 71.95% 71.31% 50.22% 189-190, 248-249, 252-253, 268-271, 274-277, 280-281, 310-321, 324-333, 428, 432, 439, 477-480, 486-493, 496, 584-596, 615-618, 625-626, 634-635, 650-651, 654-655, 658-659, 662-663, 672-682, 688-695, 712-715, 724-753, 755-792, 794-798, 820-825, 827-835, 837-846, 848-868, 870-877, 879-890, 892-905, 907-910, 912-915, 917-920, 922-925, 927-934, 939-999, 1002-1015, 1023-1024, 1032-1143, 1149-1152, 1156-1186, 1195-1210, 1214-1216, 1220-1235, 1240-1250, 1253-1325, 1328-1342, 1369, 1386, 1415-1421, 1423-1434, 1436-1443, 1465-1481, 1496-1500, 1515, 1529, 1531-1532, 1564, 1566-1567, 1573-1584, 1591-1592, 1602, 1604, 1685, 1696-1708
Generated in workflow #7504 for commit 03676b6 by the Vitest Coverage Report Action

}
}
themeMode?: 'dark' | 'light'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected empty line maybe?

@@ -18,6 +18,30 @@ import type { ConstantsUtil } from './ConstantsUtil.js'
import type { ReownName } from '../controllers/EnsController.js'
import type UniversalProvider from '@walletconnect/universal-provider'

type AppKitConfigs = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we give another name specific to event to not confuse with other type definitions? Like InitializeEventAppKitParams

Copy link
Contributor

@enesozturk enesozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomiir Approved with few comments, also as GH linter shows, there are few console logs 🙌🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants