-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add INITIALIZE event to track configuration options #3267
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
} | ||
} | ||
themeMode?: 'dark' | 'light' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected empty line maybe?
@@ -18,6 +18,30 @@ import type { ConstantsUtil } from './ConstantsUtil.js' | |||
import type { ReownName } from '../controllers/EnsController.js' | |||
import type UniversalProvider from '@walletconnect/universal-provider' | |||
|
|||
type AppKitConfigs = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we give another name specific to event to not confuse with other type definitions? Like InitializeEventAppKitParams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomiir Approved with few comments, also as GH linter shows, there are few console logs 🙌🏽
Description
Adds INITIALIZE event to track configuration options
Type of change
Checklist