Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: new divider component #3274

Merged
merged 4 commits into from
Nov 20, 2024
Merged

refactor: new divider component #3274

merged 4 commits into from
Nov 20, 2024

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Nov 19, 2024

Description

Adds new Divider component

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1481
For GH issues: closes #...

Showcase (Optional)

Screen.Recording.2024-11-19.at.18.51.42.mov

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 137c16f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:06am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:06am
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:06am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:06am
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:06am

@enesozturk enesozturk requested a review from magiziz November 19, 2024 15:52
Copy link

linear bot commented Nov 19, 2024

APKT-1481 Divider

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 335.14% 4822 / 23633
🔵 Statements 335.14% 4822 / 23633
🔵 Functions 368.54% 387 / 1430
🔵 Branches 474.44999999999993% 741 / 1721
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/ui-new/index.ts 0% 0% 0% 0%
packages/ui-new/src/components/wui-divider/styles.ts 0% 0% 0% 0%
packages/ui-new/src/utils/JSXTypeUtil.ts 100% 100% 100% 100%
packages/ui-new/src/utils/ThemeConstantsUtil.ts 100% 100% 100% 100%
Generated in workflow #7462 for commit 137c16f by the Vitest Coverage Report Action

Copy link
Contributor

@magiziz magiziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🙌

@enesozturk enesozturk deleted the feat/new-divider-component branch November 20, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants