feat: account list select component #3287
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import { html } from 'lit' | ||
| import type { Meta } from '@storybook/web-components' | ||
| import '@reown/appkit-ui-new/src/composites/wui-list-select-account' | ||
| import '../../components/gallery-container' | ||
| import type { WuiListSelectAccount } from '@reown/appkit-ui-new' | ||
| import { iconOptions } from '../../utils/PresetUtils' | ||
|
|
||
| type Component = Meta<WuiListSelectAccount> | ||
|
|
||
| export default { | ||
| title: 'Composites/wui-list-select-account', | ||
| args: { | ||
| dollars: '1740', | ||
| pennies: '72', | ||
| address: '0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045', | ||
| description: 'Email', | ||
| icon: 'mail', | ||
| disabled: false | ||
| }, | ||
| argTypes: { | ||
| dollars: { | ||
| control: { type: 'text' } | ||
| }, | ||
| pennies: { | ||
| control: { type: 'text' } | ||
| }, | ||
| address: { | ||
| control: { type: 'text' } | ||
| }, | ||
| description: { | ||
| control: { type: 'text' } | ||
| }, | ||
| icon: { | ||
| options: iconOptions, | ||
| control: { type: 'select' } | ||
| }, | ||
| disabled: { | ||
| control: { type: 'boolean' } | ||
| } | ||
| } | ||
| } as Component | ||
|
|
||
| export const Default: Component = { | ||
| render: args => html` | ||
| <gallery-container width="328"> | ||
| <wui-list-select-account | ||
| dollars=${args.dollars} | ||
| pennies=${args.pennies} | ||
| address=${args.address} | ||
| description=${args.description} | ||
| icon=${args.icon} | ||
| ?disabled=${args.disabled} | ||
| ></wui-list-select-account> | ||
| </gallery-container> | ||
| ` | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,6 @@ | ||
| import { svg } from 'lit' | ||
|
|
||
| export const mailSvg = svg`<svg viewBox="0 0 12 13" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <path d="M10.5 2.75H1.5C1.40054 2.75 1.30516 2.78951 1.23483 2.85984C1.16451 2.93016 1.125 3.02554 1.125 3.125V9.5C1.125 9.69891 1.20402 9.88968 1.34467 10.0303C1.48532 10.171 1.67609 10.25 1.875 10.25H10.125C10.3239 10.25 10.5147 10.171 10.6553 10.0303C10.796 9.88968 10.875 9.69891 10.875 9.5V3.125C10.875 3.02554 10.8355 2.93016 10.7652 2.85984C10.6948 2.78951 10.5995 2.75 10.5 2.75ZM10.125 9.5H1.875V3.97766L5.74641 7.52656C5.81559 7.59007 5.90609 7.62531 6 7.62531C6.09391 7.62531 6.18441 7.59007 6.25359 7.52656L10.125 3.97766V9.5Z" fill="currentColor"/> | ||
| </svg> | ||
| ` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these two are different properties? We should instead format the number inside. We should have such utilities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also tried removing penny value in story and there is still dot after dollars value: https://appkit-gallery-brxkv59qj-reown-com.vercel.app/?path=/docs/composites-wui-list-select-account--docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same when you remove dollar value, you see "$." in the component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added
UiHelperUtil.formatCurrencyfunction which will convert numbers into formatted dollar value 🙏