Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:fix fix swaps for SA #3303

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

:fix fix swaps for SA #3303

wants to merge 24 commits into from

Conversation

svenvoskamp
Copy link
Contributor

Description

fix swaps for SA

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 4f95183

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:21am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:21am
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:21am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:21am
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:21am

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 335.89% 4838 / 23570
🔵 Statements 335.89% 4838 / 23570
🔵 Functions 368.88% 388 / 1431
🔵 Branches 475.65999999999997% 745 / 1725
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/exports/constants.ts 0% 0% 0% 0% 1
packages/core/src/controllers/SwapController.ts 46.35% 60.6% 56.66% 46.35% 40-43, 166-167, 170-171, 180-181, 211-216, 242, 250-252, 261-265, 269-284, 287-300, 311-312, 315-316, 320-321, 329-332, 365, 372, 377-396, 405-407, 420-421, 432-433, 445, 452-453, 457-465, 493-494, 516-517, 531, 540-579, 582-627, 630-681, 685-722, 725-811, 827, 843-844
Generated in workflow #7545 for commit 4f95183 by the Vitest Coverage Report Action

Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a test covering that we don't get into the regression state again?

@arein
Copy link
Contributor

arein commented Nov 22, 2024

FYI tried on the preview link and still getting the same issue - does it maybe not take into account that I have no native token balance on this account but an eligible ERC20?

Screenshot 2024-11-22 at 11 30 03 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants