-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tenderly RPCs #301
Draft
dzimiks
wants to merge
18
commits into
reown-com:master
Choose a base branch
from
dzimiks:tenderly-rpcs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add Tenderly RPCs #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
requested changes
Aug 21, 2023
chris13524
requested changes
Aug 23, 2023
chris13524
approved these changes
Aug 25, 2023
arein
approved these changes
Sep 12, 2023
geekbrother
added a commit
that referenced
this pull request
Sep 26, 2023
geekbrother
added a commit
that referenced
this pull request
Sep 26, 2023
Thank you buddy |
Thanks buddy 🎩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #307
How Has This Been Tested?
just amigood
and got several different passes/errorsNotes
I'm pretty much done with the implementation and testing, but I have several questions and things to point out. 👀
Boba networks
on staging, should I consider removing it or it will be supported as soon as you merge these changes?just amigood
command like you suggested, I'll get errors such asassertion failed: rpc_response.error.is_none()
. What can I do there do fix this behavior?wscat -c <url>
all of them work fine.Weight::new(Priority::Normal).unwrap() work
? Am I getting all these errors because I set weight priority wrong or?Due Diligence