Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tenderly RPCs #301

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Add Tenderly RPCs #301

wants to merge 18 commits into from

Conversation

dzimiks
Copy link

@dzimiks dzimiks commented Aug 21, 2023

Description

resolves #307

  • added Tenderly node RPCs (you can find full list here)
  • wrote http and websocket providers
  • wrote tests for http and websocket connections
  • updated supported chains list
image

How Has This Been Tested?

  • I run just amigood and got several different passes/errors
  • I run tests directly from Jetbrains IDE

image
image
image

Notes

I'm pretty much done with the implementation and testing, but I have several questions and things to point out. 👀

  1. Since you don't support Boba networks on staging, should I consider removing it or it will be supported as soon as you merge these changes?
  2. If I run tests directly from the IDE, everything works for http request, but if I try with just amigood command like you suggested, I'll get errors such as assertion failed: rpc_response.error.is_none(). What can I do there do fix this behavior?
  3. When I run websocket tests, I sometimes get an error for several networks, while others are working perfectly. Also, when I try manually to connect to them using wscat -c <url> all of them work fine.
  4. Am I hitting rate limits or something like that?
  5. How Weight::new(Priority::Normal).unwrap() work? Am I getting all these errors because I set weight priority wrong or?

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@dzimiks dzimiks requested a review from chris13524 August 22, 2023 14:58
src/env/tenderly.rs Outdated Show resolved Hide resolved
@chris13524 chris13524 requested a review from arein August 25, 2023 12:23
@geekbrother geekbrother self-assigned this Sep 26, 2023
geekbrother added a commit that referenced this pull request Sep 26, 2023
geekbrother added a commit that referenced this pull request Sep 26, 2023
@geekbrother geekbrother marked this pull request as draft March 28, 2024 09:33
@Goonte
Copy link

Goonte commented May 8, 2024

Thank you buddy

@Goonte
Copy link

Goonte commented May 10, 2024

Thanks buddy 🎩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add Tenderly Node RPCs
5 participants