Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): adding the branch tag for the sub workflow #470

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

geekbrother
Copy link
Contributor

Description

This PR adds the branch tag to the reusable workflow that should possibly fix the error where the workflow is treated as action and GitHub Actions throws a following error despite checkout and the file is present:

Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '/home/runner/work/blockchain-api/blockchain-api/.github/workflows/sub-providers.yml'. Did you forget to run actions/checkout before running your local action?

How Has This Been Tested?

Not tested.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Jan 15, 2024
@geekbrother geekbrother marked this pull request as ready for review January 15, 2024 17:42
@geekbrother geekbrother requested a review from xav as a code owner January 15, 2024 17:42
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I don't think this will work. uses inside steps only supports folder actions (as the error message indicates): https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-an-action-in-the-same-repository-as-the-workflow

File-based actions are only supported at the job-level: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_iduses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants