Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(providers): unifying Solana chain_id #486

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

geekbrother
Copy link
Contributor

Description

We have two chain IDs for the Solana mainnet:

We should unify the Solana mainnet chain IDs into the single standardized solana:4sgjmw1sunhzsxgspuhpqldx6wiyjntz.

This PR adds the solana-mainnet alias for the solana:4sgjmw1sunhzsxgspuhpqldx6wiyjnt to support clients that already using the solana-mainnet, but moving forward with the unified solana:4sgjmw1sunhzsxgspuhpqldx6wiyjnt for all providers.

This will solve the load balancing for the Solana chain as well.

Slack thread context.

How Has This Been Tested?

Integration test for the Solana chain.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Jan 22, 2024
@geekbrother geekbrother marked this pull request as ready for review January 22, 2024 18:26
@geekbrother geekbrother requested a review from xav as a code owner January 22, 2024 18:26
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming Omnia supports solana:4sgjmw1sunhzsxgspuhpqldx6wiyjntz chain ID

@geekbrother
Copy link
Contributor Author

LGTM assuming Omnia supports solana:4sgjmw1sunhzsxgspuhpqldx6wiyjntz chain ID

Omnia is using sol for the solana endpoint, that doesn't changed in the PR.
solana:4sgjmw1sunhzsxgspuhpqldx6wiyjntz is ours chain_id.

@geekbrother geekbrother merged commit 9100ab7 into master Jan 23, 2024
12 checks passed
@geekbrother geekbrother deleted the fix/unifying_solana branch January 23, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants