Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(providers): adding Aurora to the init providers #488

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

geekbrother
Copy link
Contributor

Description

This PR fixing the Aurora provider. On the initial adding of the Aurora native RPC in #469 the init part was missed so the native RPC is not in the list of providers.
This issue was not caught by the compilation, lint, and our integration tests, because tests use the weighted provider and we have a few providers for the Aurora (this issue in tests is also fixed in #487 ).

How Has This Been Tested?

Tested using the Aurora integration test in #487 per provider tests.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Jan 23, 2024
@geekbrother geekbrother marked this pull request as ready for review January 23, 2024 10:46
@geekbrother geekbrother requested a review from xav as a code owner January 23, 2024 10:46
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekbrother geekbrother merged commit ae26198 into master Jan 24, 2024
12 checks passed
@geekbrother geekbrother deleted the fix/aurora_provider_fix branch January 24, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants