Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removing unwraps from the WeightedIndex #508

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: removing unwraps from the WeightedIndex #508

merged 1 commit into from
Feb 7, 2024

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Feb 7, 2024 •
edited
Loading

Description

This PR removes unwrap() from the WeightedIndex calculation and returns errors instead of panics.

This is a followup.

How Has This Been Tested?

Not tested.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Feb 7, 2024
@geekbrother geekbrother marked this pull request as ready for review February 7, 2024 16:32
@geekbrother geekbrother requested a review from xav as a code owner February 7, 2024 16:32
chris13524
chris13524 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@geekbrother
Copy link
Contributor Author

LGTM, thanks!

Thanks for catching this 🙌

@geekbrother geekbrother merged commit e1228ff into master Feb 7, 2024
20 of 23 checks passed
@geekbrother geekbrother deleted the fix/unwraps_in_weights branch February 7, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris13524 chris13524 chris13524 approved these changes

@xav xav Awaiting requested review from xav

Assignees

@geekbrother geekbrother

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geekbrother @chris13524