feat(ens): updating name attributes handler #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
force-pushed
the
feat/ens_update_attributes
branch
2 times, most recently
from
e871d57 to
817da93
Compare
geekbrother
commented
Feb 7, 2024
| if a.len() != b.len() { | ||
| /// Compare two values (either H160 or &str) in constant time to prevent timing | ||
| /// attacks | ||
| pub fn constant_time_eq(a: impl AsRef<[u8]>, b: impl AsRef<[u8]>) -> bool { |
There was a problem hiding this comment.
Making this function usable for strings and H160.
geekbrother
commented
Feb 7, 2024
| @@ -68,7 +68,7 @@ pub async fn delete_name( | |||
| } | |||
|
|
|||
| #[instrument(skip(postgres))] | |||
| pub async fn update_name( | |||
| pub async fn update_name_attributes( | |||
There was a problem hiding this comment.
Refactor this function name to reflect that it updates only attributes.
chris13524
reviewed
Feb 7, 2024
chris13524
reviewed
Feb 7, 2024
chris13524
reviewed
Feb 7, 2024
geekbrother
force-pushed
the
fix/register_endpoint_clean_up
branch
2 times, most recently
from
8c5fe98 to
21d8c27
Compare
geekbrother
force-pushed
the
feat/ens_update_attributes
branch
from
817da93 to
78100e9
Compare
geekbrother
commented
Feb 8, 2024
| const updatedAttributes = { | ||
| bio: 'integration test domain updated attribute', | ||
| bio: randomBioString, |
There was a problem hiding this comment.
Changes to use the random value here.
geekbrother
force-pushed
the
feat/ens_update_attributes
branch
from
78100e9 to
e8fab3a
Compare
chris13524
reviewed
Feb 8, 2024
chris13524
reviewed
Feb 8, 2024
chris13524
reviewed
Feb 8, 2024
chris13524
reviewed
Feb 8, 2024
chris13524
approved these changes
Feb 8, 2024
geekbrother
force-pushed
the
feat/ens_update_attributes
branch
from
e8fab3a to
2d962a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an endpoint handler to update name attributes according to the SPEC.
The following changes are made:
POST /v1/profile/account/:name/attributesendpoint is added to handle the name attributes updating,How Has This Been Tested?
The integration test was added to this PR.
Due Diligence