Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(revert): reverting transaction schema change #876

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix(revert): reverting transaction schema change #876

merged 1 commit into from
Dec 18, 2024

Conversation

geekbrother
Copy link
Contributor

Description

This PR reverting transaction schema change from data -> input.

How Has This Been Tested?

Integration tests.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Dec 18, 2024
@geekbrother
Copy link
Contributor Author

This PR reverts #872 since this broke the transaction send flow because of the schema incompatibility.

@geekbrother geekbrother marked this pull request as ready for review December 18, 2024 10:25
@geekbrother geekbrother merged commit 9a40157 into master Dec 18, 2024
15 checks passed
@geekbrother geekbrother deleted the fix/revert_schema branch December 18, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopestack nopestack nopestack approved these changes

@chris13524 chris13524 Awaiting requested review from chris13524

@jakubuid jakubuid Awaiting requested review from jakubuid

@svenvoskamp svenvoskamp Awaiting requested review from svenvoskamp

Assignees

@geekbrother geekbrother

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geekbrother @nopestack