Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CA): increasing cached gas slippage to 50 percent #878

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Dec 19, 2024

Description

This PR increases the cached gas estimation slippage from 2% to 50% to cover possibly daily spikes.

How Has This Been Tested?

Not tested.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother force-pushed the fix/increase_gas_slippage branch from 70116a1 to 4fdaa44 Compare December 19, 2024 13:17
@geekbrother geekbrother changed the title fix(CA): increasing cached gas slippage to 3 percent fix(CA): increasing cached gas slippage to 50 percent Dec 19, 2024
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geekbrother geekbrother merged commit 06d7e0d into master Dec 19, 2024
28 of 39 checks passed
@geekbrother geekbrother deleted the fix/increase_gas_slippage branch December 19, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants