feat: execute function #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2025 15:36
jakubuid
reviewed
Jan 30, 2025
jakubuid
reviewed
Jan 30, 2025
jakubuid
reviewed
Jan 30, 2025
added 2 commits
January 31, 2025 12:38
llbartekll
reviewed
Feb 3, 2025
…into feat/execute-function
jakubuid
reviewed
Feb 4, 2025
jakubuid
approved these changes
Feb 5, 2025
jakubuid
approved these changes
Feb 5, 2025
jakubuid
approved these changes
Feb 5, 2025
llbartekll
approved these changes
Feb 6, 2025
llbartekll
reviewed
Feb 6, 2025
| // FIXME this param is not used yet | ||
| pub package_name: Option<String>, | ||
| pub sdk_version: String, | ||
| pub sdk_platform: String, |
There was a problem hiding this comment.
sdk_platform is a Pulse API parameter, It accepts web, mobile, or desktop
…/github.com/reown-com/yttrium into feat/execute-function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
execute()function.Remaining work:
RPC tracing IDhttps://linear.app/reown/issue/WK-551/yttriumbcapi-rpc-tracing-idsPrepare analyticshttps://linear.app/reown/issue/WK-542/prepare-analyticsSlack conversation
Resolves WK-534
Resolves WK-389
Resolves RES-160
Resolves WK-541