fix: Safe MVP now working #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
commented
Sep 9, 2024
| @@ -309,7 +309,7 @@ mod tests { | |||
| let valid_until = 0; | |||
|
|
|||
| sol!( | |||
| struct SafeOpEntrypointV7Message { | |||
| struct SafeOp { | |||
There was a problem hiding this comment.
SignTypedData includes the struct/type name in the message. Duh
jackpooleywc
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
AA24 signature error errorto result in what appears to be a successful Safe deployment w/ initial transaction.