Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ERC-6492 signature verification #39

Merged
merged 7 commits into from
Nov 5, 2024
Merged

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Oct 11, 2024

Adds ERC-6492 signature verification to the Swift FFI bindings

Resolves RES-93

  • Switch verification to be more generic to any signature, not just personal_sign

Depends on reown-com/erc6492#3

@chris13524 chris13524 self-assigned this Oct 11, 2024
Copy link

linear bot commented Oct 11, 2024

Self { provider }
}

pub async fn verify_signature(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume for Kotlin it would be copy and paste this method

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

provider: ReqwestProvider<Ethereum>,
}

impl Erc6492Client {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that I can use this client to verify any type of accounts, EOAs and SA, correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you can verify all signature types with this

@chris13524 chris13524 merged commit 147cc96 into main Nov 5, 2024
3 checks passed
@chris13524 chris13524 deleted the feat/erc6492-verification branch November 5, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants