feat: Add kotlin bindings for UI fields method #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
requested changes
Dec 3, 2024
|
|
||
| #[derive(Debug)] | ||
| #[cfg_attr(feature = "uniffi", derive(uniffi_macros::Record))] | ||
| pub struct Eip1559EstimationFields { |
There was a problem hiding this comment.
Can we please move this stringification to kotlin-ffi so that the types in yttrium remain Rust-idiomatic? I.e. map it in kotlin-ffi's get_ui_fields() into a new set of types
The next version of UniFFI will supporting adding UniFFI to types from external crates like this Eip1559Estimation so we can remove that mapping layer
|
It may be worth rewriting/rebasing this on #77 |
chris13524
reviewed
Dec 5, 2024
| #[derive(Debug)] | ||
| #[cfg_attr(feature = "uniffi", derive(uniffi_macros::Record))] |
There was a problem hiding this comment.
Did this in my PR too: https://github.com/reown-com/yttrium/pull/73/files
|
I think we can close this in-favor of #78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.