Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearrange some deck chairs ahead of open sourcing #14

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Rearrange some deck chairs ahead of open sourcing #14

merged 3 commits into from
Nov 21, 2024

Conversation

meatballhat
Copy link
Contributor

  • move sources in a level ./src/ ➡️ ./src/monobase/
  • uv init ...
  • move local build and test dirs ./ ➡️ ./build/
  • added ./script/debug.sh
  • bump MONOBASE_PYTHON 3.12 ➡️ 3.13
  • switch shell script wrappers from calling /opt/r8/monobase/{thing}.py to python -m monobase.{thing}
  • fully qualify imports from cog import ... ➡️ from monobase.cog import ...

Connected to PLAT-554

@meatballhat meatballhat requested a review from a team as a code owner November 20, 2024 22:47
8W9aG
8W9aG approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@8W9aG 8W9aG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but lets make sure the CI is green before merging

@meatballhat
Copy link
Contributor Author

@8W9aG thank you! And yep, working on the mini tests still ⌨️

@meatballhat meatballhat marked this pull request as draft November 21, 2024 02:01
@meatballhat meatballhat marked this pull request as ready for review November 21, 2024 02:35
@meatballhat meatballhat merged commit 538e62f into main Nov 21, 2024
4 checks passed
@meatballhat meatballhat deleted the deck-chairs branch November 21, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8W9aG 8W9aG 8W9aG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meatballhat @8W9aG