-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: kots template #4533
base: main
Are you sure you want to change the base?
Feature: kots template #4533
Conversation
f1567d3
to
de3b613
Compare
cmd/kots/cli/template.go
Outdated
fmt.Println(m) | ||
} | ||
|
||
// also render helm charts with helm template if any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the rendered
directory should already have the rendered helm templates, plain k8s manifests, and additional resources created by kustomize (pull secrets and any customer patches). i think we may be able to instead just iterate and print the files in that directory?
the kotskinds will not be in rendered
, so i think what you have above this is good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks Craig! I've included rendered
directory excluding kotsadm-
files. However I think we should also run helm template
on helm/
directory for HelmChart v2. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha! I've removed the helm template part. Please let me know how it goes!
bd1eccf
to
9517886
Compare
a1f686f
to
d018228
Compare
d018228
to
c9d3ef3
Compare
c9d3ef3
to
95bc109
Compare
What this PR does / why we need it:
It is currently difficult to debug templating error thrown by KOTS during install.
Which issue(s) this PR fixes:
Special notes for your reviewer:
This PR introduce new command
kots template
with4
options to parse template.--data
flag.E.g.
kotsKind
directory, this behave similar tohelm template
where all files inkotsKind
directory will be printed to stdout. The app will be pulled from upstream.Does this PR introduce a user-facing change?
Does this PR require documentation?
Yes