Assures the current SDK version for Builders labs #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crdant
force-pushed
the
chore/keep-sdk-updated
branch
from
7832733
to
a104853
Compare
good-better-beck
suggested changes
Jul 21, 2023
| @@ -1,5 +1,5 @@ | |||
| slug: avoiding-installation-pitfalls | |||
| id: amjfqroa5bfk | |||
| id: | |||
There was a problem hiding this comment.
Should this id be blank?
There was a problem hiding this comment.
I think the id's are blanked out by the dev/prod workflow
| @@ -1,5 +1,5 @@ | |||
| slug: closing-information-gap | |||
| id: hfb41xqkyx0q | |||
| id: | |||
There was a problem hiding this comment.
I think the id's are blanked out by the dev/prod workflow
| @@ -1,5 +1,5 @@ | |||
| slug: distributing-with-replicated | |||
| id: evmpzv6ycpgs | |||
| id: | |||
There was a problem hiding this comment.
I think the id's are blanked out by the dev/prod workflow
good-better-beck
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Uses GitHub API and agent variables to keep the SDK up-to-date
Details
It was getting painful to keep the version of the Replicated SDK up-to-date in
the labs built to support the Builders experience. Right now we don't have
releases for the SDK but we do tag each version. This change uses the GitHub
API to get the latest version of the SDK (based on the tags). It then sets that
variable into an agent variable and uses it in both lifecycle scripts and
track instructions.
There is one place that still has a hard-coded SDK values: the asset that is
used to populate the static URL for the support bundle in "Closing the
Information Gap." We still don't have continuous deliver of that file the the
GCP bucket, so I'm going to defer solving the versioning issue until we
implement that. I'm not terribly concerned with it falling out of date for now,
since it is checking image pull permissions and those are going to be set at
the repository level.