Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when openExternal is called in window event handlers #153

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

sergeichestakov
Copy link
Contributor

@sergeichestakov sergeichestakov commented Mar 21, 2024

Why

We've been seeing a bug in the app where a certain repl or tab will be opened in your browser while the app is running in the background. I'm not sure why this happens tbh and can't find any logs from those that have reported this issue in Datadog (which is where we log when we open external URLs on the web side) so we should add some logging on the native side too to help us investigate. See attached Linear issue and Slack thread for more detail.

references WS-2021

What changed

Log when openExternal is called in window event handlers. Also replacing a use of the deprecated navigationUrl param while I'm at it

Test plan

  • Should see relevant logs with event details next time someone reports this

@sergeichestakov sergeichestakov self-assigned this Mar 21, 2024
Copy link

linear bot commented Mar 21, 2024

WS-2021 Replit desktop application bug: Somehow I got unauthenticated in the desktop app, while the app w...

devon.stewart said:

Replit desktop application bug: Somehow I got unauthenticated in the desktop app, while the app was in the background.
• The desktop app did not acknowledge that it was logged out, but it did trigger opening the current repl in a new tab in the browser, which stole focus from my Terminal (It just happened again as I'm typing this, taking focus from Slack!)
• The desktop app did not indicate that I was logged out until I clicked "Account" in the user's hamburger menu, but now I'm stuck in loading screen purgatory, even though every few minutes a new tab is spawned.

@sergeichestakov sergeichestakov requested review from a team, siliconjungle and szymonkaliski and removed request for a team and szymonkaliski March 21, 2024 04:00
@sergeichestakov sergeichestakov merged commit 008d62f into main Mar 21, 2024
5 checks passed
@sergeichestakov sergeichestakov deleted the @sergeichestakov/add-logs-shell-open-external branch March 21, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants