Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: improve nightly module displayVersion #337

Merged
merged 2 commits into from
May 23, 2024

Conversation

cdmistman
Copy link
Contributor

Why

showing just nightly for the rust nightly module's displayVersion isn't too helpful. let's show the date of the nightly release instead

unfortunately i can't show the release version of the stable toolchain :( fenix doesn't expose the toolchain's release version and i'm not sure it's actively maintained anymore

What changed

for rust-nightly module's displayVersion, instead of showing nightly show toolchain.cargo.version (rustc's version attr doesn't exist since it gets overwritten)

Test plan

  • nix build .#rust-nightly && jq .displayVersion result shows a date instead of "nightly"
  • nix build .#rust-stable && jq .displayVersion result still shows "stable"

Rollout

Describe any procedures or requirements needed to roll this out safely (or check the box below)

  • This is fully backward and forward compatible

@cdmistman cdmistman requested a review from a team as a code owner May 23, 2024 15:47
@cdmistman cdmistman requested review from blast-hardcheese and removed request for a team May 23, 2024 15:47
@cdmistman cdmistman enabled auto-merge May 23, 2024 15:47
@cdmistman cdmistman mentioned this pull request May 23, 2024
1 task
@cdmistman cdmistman merged commit 65bceed into main May 23, 2024
1 check passed
@cdmistman cdmistman deleted the cad/better-nightly-display-version branch May 23, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants