rust: improve nightly module displayVersion #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
showing just
nightly
for the rust nightly module's displayVersion isn't too helpful. let's show the date of the nightly release insteadunfortunately i can't show the release version of the stable toolchain :( fenix doesn't expose the toolchain's release version and i'm not sure it's actively maintained anymore
What changed
for rust-nightly module's displayVersion, instead of showing
nightly
showtoolchain.cargo.version
(rustc's version attr doesn't exist since it gets overwritten)Test plan
nix build .#rust-nightly && jq .displayVersion result
shows a date instead of"nightly"
nix build .#rust-stable && jq .displayVersion result
still shows"stable"
Rollout
Describe any procedures or requirements needed to roll this out safely (or check the box below)