python: colocate sitecustomize with python derivation output #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,6 +99,14 @@ let | |||
|
|
|||
| sitecustomize = pkgs.callPackage ./sitecustomize.nix { }; | |||
|
|
|||
| sitecustomized-python = pkgs.runCommand "python-replit-sitecustomized" {} '' | |||
| ls -al ${python.outPath} | |||
| ${pkgs.rsync}/bin/rsync -av --chown=$USER --chmod=+w ${python.outPath}/ $out/ | |||
There was a problem hiding this comment.
I am baffled that this is the only way. Doesn't this double the disk required for all python packages?
There was a problem hiding this comment.
ooooh i think you're right, i don't actually force this python's usage anywhere. i'll fix that in the morning
|
As mentioned in your one-on-one chat. I'd like to abandon making changes to python and patch the repo unless we get more data points that this is a widespread problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
pylint makes some assumptions about the format of
PYTHONPATH🙄What changed
changed the python wrapper to use the output of a new derivation that:
pythonderivation outputsitecustomize.pyif it existssitecustomize.pyTest plan
python template tests pass
Rollout
Describe any procedures or requirements needed to roll this out safely (or check the box below)