Make moduleit exit with 1 if nix-build fails #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airportyh
requested review from
ryantm and
cdmistman
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When moduleit fails due to nix-build, it still returns exit code 0. Causing Nix modules to emit a .res file without an error.
Context: https://replit.slack.com/archives/C03KS2B221W/p1690387564427729
What changed
If nix-build fails, moduleit returns exit code 1.
Test plan
Try compiling the nix files in https://replit.com/join/xgtafsfodg-coltonatreplit with moduleit. It should fail and
echo $?should give 1